Post refactor clean-up

This commit is contained in:
emelko
2018-07-16 12:39:11 +02:00
parent 0da3810aeb
commit 6f755c55dc
6 changed files with 30 additions and 289 deletions
-102
View File
@@ -1,102 +0,0 @@
import React, { Component } from 'react'
import {
View,
Button,
Text,
Switch
} from 'react-native'
import RadioForm from 'react-native-simple-radio-button'
import styles from '../styles/index'
import { saveBleeding } from '../db'
import { bleeding as bleedingLabels } from '../labels/labels'
export default class Bleeding extends Component {
constructor(props) {
super(props)
this.cycleDay = props.cycleDay
this.showView = props.showView
let bleedingValue = this.cycleDay.bleeding && this.cycleDay.bleeding.value
if (! (typeof bleedingValue === 'number') ){
bleedingValue = -1
}
this.state = {
currentValue: bleedingValue,
exclude: this.cycleDay.bleeding ? this.cycleDay.bleeding.exclude : false
}
}
render() {
const bleedingRadioProps = [
{label: bleedingLabels[0], value: 0 },
{label: bleedingLabels[1], value: 1 },
{label: bleedingLabels[2], value: 2 },
{label: bleedingLabels[3], value: 3 },
]
return (
<View style={ styles.symptomEditView }>
<View style={ styles.symptomEditSplitSymptomsAndLastRowButtons }>
<View style={ styles.symptomEditListedSymptomView }>
<View style={{flex: 1}}>
<Text style={styles.symptomDayView}>Bleeding</Text>
</View>
<View style={{flex: 1}}>
<RadioForm
radio_props={bleedingRadioProps}
initial={this.state.currentValue}
formHorizontal={true}
labelHorizontal={false}
labelStyle={styles.radioButton}
onPress={(itemValue) => {
this.setState({currentValue: itemValue})
}}
/>
</View>
</View>
<View style={ styles.itemsInRowSeparatedView }>
<View style={ styles.singleButtonView }>
<Text style={ styles.symptomDayView }>Exclude</Text>
</View>
<View style={ styles.singleButtonView }>
<Switch
onValueChange={(val) => {
this.setState({exclude: val})
}}
value={this.state.exclude}
/>
</View>
</View>
</View>
<View style={ styles.itemsInRowSeparatedView }>
<View style={ styles.singleButtonView }>
<Button
onPress={() => this.showView('dayView')}
title="Cancel">
</Button>
</View>
<View style={ styles.singleButtonView }>
<Button
onPress={() => {
saveBleeding(this.cycleDay)
this.showView('dayView')
}}
title="Delete">
</Button>
</View>
<View style={ styles.singleButtonView }>
<Button
onPress={() => {
saveBleeding(this.cycleDay, {
value: this.state.currentValue,
exclude: this.state.exclude
})
this.showView('dayView')
}}
disabled={ this.state.currentValue === -1 }
title="Save">
</Button>
</View>
</View>
</View>
)
}
}
+1 -1
View File
@@ -24,7 +24,7 @@ export default function (showView) {
saveAction() saveAction()
showView('dayView') showView('dayView')
}, },
disabled: saveDisabled disabledCondition: saveDisabled
} }
] ]
+5 -7
View File
@@ -10,9 +10,9 @@ import {
mucusFeeling as feelingLabels, mucusFeeling as feelingLabels,
mucusTexture as textureLabels, mucusTexture as textureLabels,
mucusNFP as computeSensiplanMucusLabels, mucusNFP as computeSensiplanMucusLabels,
} from '../labels/labels' } from './labels/labels'
import cycleDayModule from '../lib/get-cycle-day-number' import cycleDayModule from '../../lib/get-cycle-day-number'
import { bleedingDaysSortedByDate } from '../db' import { bleedingDaysSortedByDate } from '../../db'
const getCycleDayNumber = cycleDayModule() const getCycleDayNumber = cycleDayModule()
@@ -91,11 +91,9 @@ export default class DayView extends Component {
</Button> </Button>
</View> </View>
</View> </View>
<View style={ styles.itemsInRowSeparatedView }> <View style={ styles.symptomViewRowInline }>
<View style={{flex: 1}}>
<Text style={styles.symptomDayView}>Mucus</Text> <Text style={styles.symptomDayView}>Mucus</Text>
</View> <View style={ styles.symptomEditButton }>
<View style={ styles.singleButtonView }>
<Button <Button
onPress={() => this.showView('mucusEditView')} onPress={() => this.showView('mucusEditView')}
title={mucusLabel}> title={mucusLabel}>
+3 -3
View File
@@ -45,9 +45,9 @@ export default class Day extends Component {
<View> <View>
{ {
{ dayView: <DayView cycleDay={this.cycleDay} showView={this.showView} />, { dayView: <DayView cycleDay={this.cycleDay} showView={this.showView} />,
bleedingEditView: <BleedingEditView cycleDay={this.cycleDay} showView={this.showView}/>, bleedingEditView: <BleedingEditView cycleDay={this.cycleDay} makeActionButtons={this.makeActionButtons}/>,
temperatureEditView: <TemperatureEditView cycleDay={this.cycleDay} showView={this.showView}/>, temperatureEditView: <TemperatureEditView cycleDay={this.cycleDay} makeActionButtons={this.makeActionButtons}/>,
mucusEditView: <MucusEditView cycleDay={this.cycleDay} showView={this.showView}/> mucusEditView: <MucusEditView cycleDay={this.cycleDay} makeActionButtons={this.makeActionButtons}/>
}[this.state.visibleComponent] }[this.state.visibleComponent]
} }
</View > </View >
+20 -18
View File
@@ -1,7 +1,6 @@
import React, { Component } from 'react' import React, { Component } from 'react'
import { import {
View, View,
Button,
Text, Text,
Switch Switch
} from 'react-native' } from 'react-native'
@@ -12,25 +11,27 @@ import {
mucusFeeling as feelingLabels, mucusFeeling as feelingLabels,
mucusTexture as textureLabels mucusTexture as textureLabels
} from '../labels/labels' } from '../labels/labels'
import computeSensiplanValue from '../../../lib/sensiplan-mucus'
export default class Mucus extends Component { export default class Mucus extends Component {
constructor(props) { constructor(props) {
super(props) super(props)
this.cycleDay = props.cycleDay this.cycleDay = props.cycleDay
this.showView = props.showView this.makeActionButtons = props.makeActionButtons
this.currentFeelingValue = this.cycleDay.mucus && this.cycleDay.mucus.feeling
if (typeof this.currentFeelingValue !== 'number') {
this.currentFeelingValue = -1
}
this.currentTextureValue = this.cycleDay.mucus && this.cycleDay.mucus.texture
if (typeof this.currentTextureValue !== 'number') {
this.currentTextureValue = -1
}
this.state = { this.state = {
exclude: this.cycleDay.mucus ? this.cycleDay.mucus.exclude : false exclude: this.cycleDay.mucus ? this.cycleDay.mucus.exclude : false
} }
this.state.currentFeelingValue = this.cycleDay.mucus && this.cycleDay.mucus.feeling
if (typeof this.state.currentFeelingValue !== 'number') {
this.state.currentFeelingValue = -1
}
this.state.currentTextureValue = this.cycleDay.mucus && this.cycleDay.mucus.texture
if (typeof this.state.currentTextureValue !== 'number') {
this.state.currentTextureValue = -1
}
} }
render() { render() {
@@ -52,12 +53,12 @@ export default class Mucus extends Component {
<View style={styles.radioButtonRow}> <View style={styles.radioButtonRow}>
<RadioForm <RadioForm
radio_props={mucusFeelingRadioProps} radio_props={mucusFeelingRadioProps}
initial={this.state.currentValue} initial={this.state.currentFeelingValue}
formHorizontal={true} formHorizontal={true}
labelHorizontal={false} labelHorizontal={false}
labelStyle={styles.radioButton} labelStyle={styles.radioButton}
onPress={(itemValue) => { onPress={(itemValue) => {
this.currentFeelingValue = itemValue this.setState({ currentFeelingValue: itemValue })
}} }}
/> />
</View> </View>
@@ -65,12 +66,12 @@ export default class Mucus extends Component {
<View style={styles.radioButtonRow}> <View style={styles.radioButtonRow}>
<RadioForm <RadioForm
radio_props={mucusTextureRadioProps} radio_props={mucusTextureRadioProps}
initial={this.currentTextureValue} initial={this.state.currentTextureValue}
formHorizontal={true} formHorizontal={true}
labelHorizontal={false} labelHorizontal={false}
labelStyle={styles.radioButton} labelStyle={styles.radioButton}
onPress={(itemValue) => { onPress={(itemValue) => {
this.currentTextureValue = itemValue this.setState({ currentTextureValue: itemValue })
}} }}
/> />
</View> </View>
@@ -91,8 +92,9 @@ export default class Mucus extends Component {
cycleDay: this.cycleDay, cycleDay: this.cycleDay,
saveAction: () => { saveAction: () => {
saveSymptom('mucus', this.cycleDay, { saveSymptom('mucus', this.cycleDay, {
feeling: this.currentFeelingValue, feeling: this.state.currentFeelingValue,
texture: this.currentTextureValue, texture: this.state.currentTextureValue,
computedNfp: computeSensiplanValue(this.state.currentFeelingValue, this.state.currentTextureValue),
exclude: this.state.exclude exclude: this.state.exclude
}) })
}, },
-157
View File
@@ -1,157 +0,0 @@
import React, { Component } from 'react'
import {
View,
Button,
Text,
Switch
} from 'react-native'
import RadioForm from 'react-native-simple-radio-button'
import { saveMucus } from '../db'
import styles from '../styles/index'
import {
mucusFeeling as feelingLabels,
mucusTexture as textureLabels
} from '../labels/labels'
import computeSensiplanValue from '../lib/sensiplan-mucus'
export default class Mucus extends Component {
constructor(props) {
super(props)
this.cycleDay = props.cycleDay
this.showView = props.showView
let currentFeelingValue = this.cycleDay.mucus && this.cycleDay.mucus.feeling
if (typeof currentFeelingValue !== 'number') {
currentFeelingValue = -1
}
let currentTextureValue = this.cycleDay.mucus && this.cycleDay.mucus.texture
if (typeof currentTextureValue !== 'number') {
currentTextureValue = -1
}
this.state = {
currentFeelingValue,
currentTextureValue,
computeSensiplanValue,
exclude: this.cycleDay.mucus ? this.cycleDay.mucus.exclude : false
}
}
render() {
const mucusFeelingRadioProps = [
{label: feelingLabels[0], value: 0 },
{label: feelingLabels[1], value: 1 },
{label: feelingLabels[2], value: 2 },
{label: feelingLabels[3], value: 3 }
]
const mucusTextureRadioProps = [
{label: textureLabels[0], value: 0 },
{label: textureLabels[1], value: 1 },
{label: textureLabels[2], value: 2 }
]
return(
<View style={ styles.symptomEditView }>
<View style={ styles.symptomEditSplitSymptomsAndLastRowButtons }>
<View style={ styles.symptomEditListedSymptomView }>
<View style={{flex: 1}}>
<Text style={styles.symptomDayView}>Mucus</Text>
</View>
<View style={{flex: 1}}>
<Text style={styles.symptomDayView}>Feeling</Text>
</View>
<View style={{flex: 1}}>
<RadioForm
radio_props={mucusFeelingRadioProps}
initial={this.state.currentFeelingValue}
formHorizontal={true}
labelHorizontal={false}
labelStyle={styles.radioButton}
onPress={(itemValue) => {
this.setState({currentFeelingValue: itemValue})
}}
/>
</View>
<View style={{flex: 1}}>
<Text style={styles.symptomDayView}>Color/Texture</Text>
</View>
<View style={{flex: 1}}>
<RadioForm
radio_props={mucusTextureRadioProps}
initial={this.state.currentTextureValue}
formHorizontal={true}
labelHorizontal={false}
labelStyle={styles.radioButton}
onPress={(itemValue) => {
this.setState({currentTextureValue: itemValue})
}}
/>
</View>
</View>
<View style={ styles.itemsInRowSeparatedView }>
<View style={ styles.singleButtonView }>
<Text style={ styles.symptomDayView }>Exclude</Text>
</View>
<View style={ styles.singleButtonView }>
<Switch
onValueChange={(val) => {
this.setState({exclude: val})
}}
value={this.state.exclude}
/>
</View>
</View>
</View>
<View style={ styles.itemsInRowSeparatedView }>
<View style={ styles.singleButtonView }>
<Button
onPress={() => this.showView('dayView')}
title="Cancel">
</Button>
</View>
<View style={ styles.singleButtonView }>
<Button
onPress={() => {
saveMucus(this.cycleDay)
this.showView('dayView')
}}
title="Delete">
</Button>
</View>
<View style={ styles.singleButtonView }>
<Button
onPress={() => {
saveMucus(this.cycleDay, {
feeling: this.state.currentFeelingValue,
texture: this.state.currentTextureValue,
computedNfp: computeSensiplanValue(this.state.currentFeelingValue, this.state.currentTextureValue),
exclude: this.state.exclude
})
this.showView('dayView')
}}
disabled={ this.state.currentFeelingValue === -1 || this.state.currentTextureValue === -1 }
title="Save">
</Button>
</View>
</View>
</View>
)
}
}