506: Review changes.

components/settings/customization/advance-notice-days-slider.js

@@ -2,8 +2,8 @@ import React from 'react'
 import { View } from 'react-native'
 import PropTypes from 'prop-types'
 import Slider from '@ptomasroos/react-native-multi-slider'
-import SliderLabel from './slider-label'
 
+import SliderLabel from './slider-label'
 import { styles } from './slider-styles'
 import {
   ADVANCE_PERIOD_NOTICE_DAYS_MIN,

components/settings/customization/slider-styles.js

@@ -8,7 +8,6 @@ export const styles = StyleSheet.create({
   },
   marker: {
     backgroundColor: Colors.turquoiseDark,
-
     borderRadius: 50,
     elevation: 4,
     height: Sizes.subtitle,

components/settings/customization/temperature-slider.js

@@ -3,13 +3,12 @@ import { View } from 'react-native'
 import PropTypes from 'prop-types'
 import Slider from '@ptomasroos/react-native-multi-slider'
 
-import alertError from '../common/alert-error'
 import SliderLabel from './slider-label'
-
+import { styles } from './slider-styles'
+import alertError from '../common/alert-error'
 import { scaleObservable, saveTempScale } from '../../../local-storage'
 import labels from '../../../i18n/en/settings'
 import { TEMP_MIN, TEMP_MAX, TEMP_SLIDER_STEP } from '../../../config'
-import { styles } from './slider-styles'
 
 const TemperatureSlider = ({ disabled }) => {
   const savedValue = scaleObservable.value

components/settings/reminders/period-reminder.js

@@ -32,18 +32,23 @@ const PeriodReminder = () => {
     saveAdvanceNoticeDays(days)
   }
 
+  const reminderText =
+    advanceNoticeDays == 1
+      ? labels.periodReminder.reminderTextSingular
+      : labels.periodReminder.reminderTextPlural(advanceNoticeDays)
+
   return (
     <>
       <AppSwitch
         onToggle={periodReminderToggle}
-        text={labels.periodReminder.reminderText(advanceNoticeDays)}
+        text={reminderText}
         value={isPeriodReminderEnabled}
         disabled={isPeriodPredictionDisabled}
       />
       {isPeriodReminderEnabled && (
         <AdvanceNoticeDaysSlider
           disabled={isPeriodPredictionDisabled}
-          advanceNoticeDays={parseInt(advanceNoticeDays, 10)}
+          advanceNoticeDays={parseInt(advanceNoticeDays)}
           onAdvanceNoticeDaysChange={handleAdvanceNoticeDaysChange}
         />
       )}